Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGVF-2276-calc-cls #1290

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

IGVF-2276-calc-cls #1290

wants to merge 13 commits into from

Conversation

ian-whaling
Copy link
Contributor

No description provided.

@ian-whaling ian-whaling force-pushed the IGVF-2276-calc-cls branch 2 times, most recently from d96db74 to 62bc778 Compare February 11, 2025 00:38
@ian-whaling ian-whaling requested a review from shengchd February 18, 2025 17:37
@@ -2,6 +2,7 @@

### Minor changes since schema version 9

* Add calculated property `construct_library_sets`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add 'update calculation of assay_titles' and summary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually only assay_titles I think

Copy link
Contributor

@shengchd shengchd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! have a minor request on changelog.

shengchd
shengchd previously approved these changes Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants